ecamp / ecamp/ecamp3

Improve Design of campCollaborationDisplayName

Open
#3,437 0 comments 0 reactions 0 assignees View on GitHub
agents:ignore
Dominant language
PHP
Stars
156
Forks
72
Avg merge
12h 43m
Merged PRs (30d)
203

Description

In #3436 and #3435 we saw that the design of campCollaborationDisplayName is not optimal.
It does not guide the developer to use the function correctly.
Possible Ideas:
1. Separate the 2 concerns into 2 functions
2. Add a chainable interface that only allows to use the indicateInactive feature if tc is not null
3. Only allow this plugin to be used as Vue Plugin where tc is available
....

Contributor guide

Open the contributing guide

Research direction

Start by reading the implementation of campCollaborationDisplayName and the context from issues #3435 and #3436. Compare the concerns described there and determine which API design is appropriate, then verify that the resulting interface guides correct use of tc and indicateInactive.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.