easystats / easystats/performance

supporting `nls` models in `check_model`

Open
#327 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement :boom:
Dominant language
R
Stars
1.2k
Forks
109
Avg merge
6h 34m
Merged PRs (30d)
8

Description

Feature request from Twitter

library(performance)

require(graphics)
DNase1 <- subset(DNase, Run == 1)
fm1DNase1 <- nls(density ~ SSlogis(log(conc), Asym, xmid, scal), DNase1)

check_model(fm1DNase1)
#> Error in `[.data.frame`(insight::get_data(x, verbose = verbose), , pred, : undefined columns selected

Created on 2021-07-10 by the reprex package (v2.0.0)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the R example with DNase1 and nls(), then trace the check_model(fm1DNase1) entry point to identify where the model data is handled. Done means check_model accepts this nls model without the reported undefined-columns error and preserves its existing behavior for other models.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.