easystats / easystats/parameters
data attribute in principal_component
Nobody has claimed this yet.
- Dominant language
- R
- Stars
- 499
- Forks
- 45
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 3
Description
That's minor but I just noticed that the data name and dataset as saved under these names, which is a bit counterintuitive (I would have expected data to be the dataset and for the name something like data_name or such). Do you have in mind if this is used in other places that in this context (to see whether it would be a problem to change it)?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at R/principal_components.R lines 199-200 and inspect how the data and data-name attributes are assigned. Search the repository for both attribute names to determine whether renaming would affect other uses; done means the names are intuitive and all references remain consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100