eWaterCycle / eWaterCycle/grpc4bmi

Bind to localhost instead of 0.0.0.0

Open
#59 1 comment 0 reactions 1 assignee Claimed by @goord View on GitHub
Dominant language
Python
Stars
5
Forks
5
PR merge metrics
No merged PRs in 30d

Description

The BmiClientDocker and BmiClientSingularity now create Docker and Singularity containers with a random port bounded to 0.0.0.0 . This seems too much permission because client and server are located on the same machine so binding to `localhost` and `127.0.0.1` should be enough.

Could an extra argument be added to the constructor with `host='localhost'` of the BimClient* classes?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.