eWaterCycle / eWaterCycle/grpc4bmi

`MemoizedBmi` has incorrect `set_value_at_indices` kwarg

Open
#155 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
5
Forks
5
PR merge metrics
No merged PRs in 30d

Description

`MemoizedBmi` has the following method `set_value_at_indices`

```py
def set_value_at_indices(self, var_name, indices, src):
return self.origin.set_value_at_indices(var_name, indices, src)
```

However, the BMI spec (and the OptionalDestBmi & BmiClient) has the following method signature:
```py
def set_value_at_indices(self, name, inds, src):
```

If a user uses kwargs with the memoized bmi this will go wrong.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.