eWaterCycle / eWaterCycle/grpc4bmi

BmiJulia easier to subclass.

Open
#145 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
5
PR merge metrics
No merged PRs in 30d

Description

To subclass the BmiJulia class you now have to something like

```python
class WflowBmi(BmiJulia):
def __init__(self):
m = self.from_name("Wflow.Model", implementation_name="Wflow.BMI")
super().__init__(m.model, m.implementation)
```

See https://github.com/eWaterCycle/grpc4bmi/pull/144/files#r1374200483

It would be nicer if you could do

```
class WflowBmi(BmiJulia):
def __init__(self):
super().__init__("Wflow.Model", "Wflow.BMI")
```

Con: this makes __init__ fat as it needs to call julia code +

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.