eWaterCycle / eWaterCycle/grpc4bmi

BmiClientSingularity should use own logger

Open
#103 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5
Forks
5
PR merge metrics
No merged PRs in 30d

Description

It uses global logging at https://github.com/eWaterCycle/grpc4bmi/blob/1882d5f80c6a471a6eba5f2cd34f9a2fc896d6d7/grpc4bmi/bmi_client_singularity.py#L222

I should be using a local logger with
```
import logging
logger = logging.getLogger(__name__)
...
logger.info('Running /....sif singularity container on port 41749')
```

Then its message can be silenced selectively.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.