eWaterCycle / eWaterCycle/ewatercycle

caravan forcing downloads and unzips shapefiles for all caravan with each basin: leads to errors

Open
#478 0 comments 0 reactions 1 assignee Claimed by @RolfHut View on GitHub
bug enhancement
Dominant language
Python
Stars
41
Forks
6
Avg merge
8d 23h
Merged PRs (30d)
2

Description

When generating forcing from caravan, the entire caravan shapefile (100 MB) is downloaded and unzipped each time, unless a path to the shapefile of the individual basin is provided. Timing issues between python and OS (I think?) cause this to fail when multiple catchments are requested in rapid succession.

As a researcher who wants to study the entire camels dataset for my research, I want to be able to point to a location where the combined shapefile is stored (cached) to avoid this overhead.

A solution would be to check if the current optional "shape" argument points to a file called "combined.shp". If it does, it is assumed this is the combined caravan shapefile and the shape of the selected catchment is extracted from it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.