eWaterCycle / eWaterCycle/ewatercycle

sif file corrupted and no DeadContainerException

Open
#278 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
41
Forks
6
Avg merge
8d 23h
Merged PRs (30d)
2

Description

We had a corrupt SIF file, to check ran `singularity run `, it printed `could not open image : SIF image is corrupted: wrong partition size`.

I expected DeadContainerException to be thrown at https://github.com/eWaterCycle/grpc4bmi/blob/d4e644a3177774e348295f78c2c4061094858256/grpc4bmi/bmi_client_singularity.py#L235, but instead the BmiClientSingularity was stuck on connecting to a grpc server that died prematurely.

Can we make it possible to set the `delay` and `timeout` in the grpc4bmi.bmi_client_singularity.BmiClientSingularity construtor?
So we give some time for the container to die instead of immediatly checking
This could be done by passing `delay` in the model.setup() method or in the ewatercycle.yaml file.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.