eWaterCycle / eWaterCycle/ewatercycle

Add return types to forcing methods

Open
#263 2 comments 0 reactions 0 assignees View on GitHub
forcing
Dominant language
Python
Stars
41
Forks
6
Avg merge
8d 23h
Merged PRs (30d)
2

Description

In #261 the return types of the `load()`, `load_foreign()` and `generate()` methods in `ewatercycle.forcing` where removed due to using them in notebooks gave mypy errors. So when using these methods you fall back to [dynamically typed code](https://mypy.readthedocs.io/en/stable/dynamic_typing.html#dynamically-typed-code) at runtime.

It would be nice if return types could be restored somehow so while coding you can autocomplete attributes of the forcing object without having to have forcing object at runtime.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.