eWaterCycle / eWaterCycle/ewatercycle-wflow
netcdfinput of Wflow model too truncated
- Dominant language
- Python
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
On https://github.com/eWaterCycle/ewatercycle/blob/29d3aed18fb39b3bedb41bac2fd8e9c7277e31be/ewatercycle/models/wflow.py#L59
`Path(forcing.netcdfinput).name` is used. Some [wflow examples](https://github.com/openstreams/wflow/search?q=netcdfinput) use `inmaps/inmaps.nc`, These examples will not be able to run by `ewatercycle.models.Wflow` class.
As only storing the name (`inmaps.nc`) will cause the model to not find the file.
Can the `.name` be replaced with something that works when inmaps.nc is in a subdirectory of the parameter set?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at ewatercycle/models/wflow.py line 59 and inspect how the Wflow model handles the netcdfinput path from the parameter set. Reproduce the issue with a value such as inmaps/inmaps.nc; done means the model can locate and run with a netcdfinput file stored in a subdirectory.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100