eWaterCycle / eWaterCycle/ewatercycle-hype
Don't copy forcing for Hype model
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
At the moment the forcings are copied to the working directory at https://github.com/eWaterCycle/ewatercycle/blob/107db173115cd35bfac42b5aaac9842580b9b45a/src/ewatercycle/models/hype.py#L123
Hype can be configured with `forcingdir` in `info.txt`, see http://www.smhi.net/hype/wiki/doku.php?id=start:hype_file_reference:info.txt
By setting `forcingDir` and mounting the forcing dir into the container we could make the `ewatercycle.models.Hype.setup()` method quicker and more similar to other models.
We should check that all files the model sees as forcing files are actually in the ewatercycle forcing object. If not then model could die due to misplaced files.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in src/ewatercycle/models/hype.py at the forcing-copy logic around line 123 and inspect ewatercycle.models.Hype.setup(). Check how info.txt configures forcingdir and how the forcing directory is mounted into the container. Done means setup no longer copies forcing files, and all forcing files visible to HYPE are verified to come from the forcing object.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100