ModalHolder transition animation missing
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.3k
- Forks
- 127
- PR merge metrics
- No merged PRs in 30d
Description
When using ModalHolder, the transition animation is missing. I think the update logic for ALREADY_MOUNTED should be modified to match the return logic of the create HOC. Specifically, ALREADY_MOUNTED[id] should only be set to true when shouldMount is true.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ModalHolder update logic and the create HOC return logic, then compare how ALREADY_MOUNTED[id] is set when shouldMount changes. Confirm the fix by verifying that ModalHolder transitions animate when a modal is mounted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100