eBay / eBay/nice-modal-react

defaultVisible

Open
#150 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.3k
Forks
127
PR merge metrics
No merged PRs in 30d

Description

Hello, I can’t seem to pass the "true" value in defaultVisible to a created and registered modal window, how can I do this correctly?
Typescript suggests exactly this method, but no matter how hard I try, I can’t pass the defaultVisible value

const DesktopMenu = loadable(
  () => import('src/entities/menu').then((mod) => mod.DesktopMenu),
  {
    ssr: false,
  }
);

const DesktopMenuWithProps = NiceModal.create(DesktopMenu);

const registar = () => {
  NiceModal.register('desktop-menu', DesktopMenuWithProps, {
    defaultVisible: true,
  });
};

export const ModalProvider: React.FC = ({ children }) => {
  registar();
  return <NiceModal.Provider>{children}</NiceModal.Provider>;
};

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the NiceModal.register entry point and the ModalProvider registration shown in the issue, then trace how defaultVisible is handled for the registered DesktopMenuWithProps modal. Confirm the intended behavior by checking whether the modal becomes visible when the provider mounts.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.