eBay / eBay/digital-signature-java-sdk

SignatureConfig - Lack of Setters

Open
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
11
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Hi all,

After the latest changes made in version 1.1.0-RELEASE shouldn't SignatureConfig have setters for all the properties that one needs to set ?

Also why the default constructor is calling the addProvider ?

    public SignatureConfig() {
        Security.addProvider(new BouncyCastleProvider());
    }

How one is supposed to leverage the new Signature if the SignatureConfig is a dummy one ?

Thanks in advance for your time.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the SignatureConfig class and its default constructor. Determine which properties need setters and how provider registration should behave, then define the expected configuration and constructor behavior before changing the SDK.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cryptography, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.