eBay / eBay/HomeStore

index service should add index table automatically after initialization

Open
#666 0 comments 0 reactions 1 assignee View on GitHub

@yamingk is already working on this.

Since Mar 18, 2025.

Dominant language
C++
Stars
29
Forks
30
Avg merge
2d 4h
Merged PRs (30d)
6

Description

After looking through the index service public api, it looks a little inconsistent that the consumer will need to call add_index_table() to homestore::hs()->index_service() for the first time creation, however in the recovery path, it doesn't need to do so (because index_service does that as part of index_table recovery&init).
I am going to formalize the API, consumer just need to initialize the index table but does't need to call add_index_table to index service. We can discuss in next HS meeting.
Discussion: https://ebay-eng.slack.com/archives/CAVQXEAKS/p1741736815804929

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.