Clarify client-proxy health port defaults across binary config and Nomad IaC
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.6k
- Forks
- 438
- PR merge metrics
- No merged PRs in 30d
Description
I know this is not a big issue, but still confused. I noticed two different defaults for client-proxy health port:
- packages/client-proxy/internal/cfg/model.go
HEALTH_PORTdefault is3003- iac/modules/job-client-proxy/variables.tf
health_portdefault is3001
- iac/provider-gcp/variables.tf
client_proxy_health_port.portdefault is also3001
The Nomad job sets HEALTH_PORT from NOMAD_PORT_health, so deployments using the module can work with 3001. However, the binary default and some self-hosted deployments
appear to use 3003.
If not intentional, we can align either the binary default or the IaC default to 3001.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the defaults in packages/client-proxy/internal/cfg/model.go, iac/modules/job-client-proxy/variables.tf, and iac/provider-gcp/variables.tf, then trace how the Nomad job assigns HEALTH_PORT from NOMAD_PORT_health. The work is done when the intended health port is chosen and the binary and IaC defaults are aligned accordingly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, terraform
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100