dylibso / dylibso/modsurfer

consider changing imports `include` name

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
134
Forks
5
PR merge metrics
No merged PRs in 30d

Description

After the recent change in #45, we broke a Tezos example: https://github.com/dylibso/modsurfer/actions/runs/4928214424/jobs/8806287884

This is because the checkfile only has a single import, given that the past semantics of `imports.include` were such that a module had to have _at least_ the specified imports. Now that we've updated this to mean "the module must have a subset of these imports, but no others", the validation fails for this example.

A consideration would be to change the name from `includes` here to something less restrictive... maybe `allow` ?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.