dylibso / dylibso/chicory

Review Exceptions and Exception types

Open
#630 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
1.1k
Forks
71
PR merge metrics
No merged PRs in 30d

Description

Noticed those lines:

https://github.com/dylibso/chicory/blob/6cba00b6c30ad006fe63ed00365466dd59c4e4c3/test-gen-plugin/src/main/java/com/dylibso/chicory/maven/JavaTestGen.java#L306-L308

probably catching a generic `ChicoryException` is too broad and we should review which Exception should be thrown.

Contributor guide

Open the contributing guide

Research direction

Start at test-gen-plugin/src/main/java/com/dylibso/chicory/maven/JavaTestGen.java around lines 306-308 and review the exception handling there. Trace which exception types can be thrown and determine the intended narrower exceptions; done means the generic ChicoryException catch and thrown exception types have been appropriately reviewed.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.