Investigate handling of type IDs
Open
- Dominant language
- Java
- Stars
- 1.1k
- Forks
- 71
- PR merge metrics
- No merged PRs in 30d
Description
The following methods evaluate type IDs:
* `com.dylibso.chicory.runtime.TypeValidator#getReturns`
* `com.dylibso.chicory.runtime.InterpreterMachine#numberOfValuesToReturn`
* `com.dylibso.chicory.aot.AotMachine#blockType`
They compare the value to the special `0x40` epsilon value and the ID constants. Unless I'm missing something, these will return the wrong result for modules with more than 64 types (which seems not to be covered by the specification testsuite). I believe this needs to be handled in the parser when decoding the binary type ID values.
Contributor guide
Assessment
This issue has not been assessed yet.