dwyl / dwyl/rbac

Stub Dependency on Auth App

Open
#18 0 comments 0 reactions 0 assignees View on GitHub
chore enhancement help wanted priority-2 T2h technical
Dominant language
Elixir
Stars
34
Forks
1
Avg merge
5m
Merged PRs (30d)
1

Description

As noted in https://github.com/dwyl/rbac/issues/16#issuecomment-935804847 the `rbac` tests have a dependency on the `auth` (Heroku) App. This is obviously undesirable especially when the `auth` App is offline ... 🤦‍♂️

# Todo

+ [ ] borrow the idea from "Inject Poison" mocking similar to how we do it in:
https://github.com/dwyl/elixir-auth-github/blob/9740fd3d7f90230d2b5e8f627e8f31b98b97a72b/lib/elixir_auth_github.ex#L17-L19
+ [ ] Completely mock the requests that go to `auth` so that the `rbac` tests run offline.
+ [ ] have the `option` to run the tests in "e2e" mode so that they run integration with `auth`.
+ [ ] Create PR
+ [ ] Publish new version to Hex.pm

This is a "nice to have" once other `priority-1` and `priority-2` tasks are complete.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.