dwyl / dwyl/gogs-server

Using image vs fly.toml for launching app

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
question
Dominant language
No language data
Stars
5
Forks
0
PR merge metrics
No merged PRs in 30d

Description

On the [create an app](https://github.com/dwyl/gogs-server#create-an-app) section we have the following command:

```sh
flyctl launch --name gogs-server --image gogs/gogs --org dwyl
```
This will create a new Fly app with the gogs image, (I guess from https://hub.docker.com/r/gogs/gogs).
However the `fly.toml`also contains in the build section the gogs image:
https://github.com/dwyl/gogs-server/blob/5e434c77823de8240e761ea938cf4d16c57870cb/fly.toml#L12-L13

So could we instead of using the `--image gogs/gogs` flag, just run

```sh
flyctl launch --name gogs-server --org dwyl
```
We could also not pass the `--org` flag and let the command line ask later on the launch step I think.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.