dwyl / dwyl/email

2023 Rebuild?

Open
#77 2 comments 0 reactions 0 assignees View on GitHub
chore discuss T25m technical
Dominant language
Elixir
Stars
44
Forks
1
Avg merge
18h 25m
Merged PRs (30d)
1

Description

As noted a couple of years back: https://github.com/dwyl/contact/issues/8 `swoosh` _already_ had all the features we needed for _basic_ email sending. What it _lacked_ was _deliverability_ tracking. Which was why I didn't use it at the time.
But now that `swoosh` is included by `default` in `Phoenix 1.6.x` it's the "defacto".

That is simultaneously an annoying thing - because there's lots of @dependabot noise https://github.com/search?q=org%3Adwyl+swoosh&type=issues ... - and a _really_ good thing because the decision is _made_. ✅

So the question is: should `email` be _separate_ from `auth`?
Or are we fragmenting our backend too much by making them separate apps? 🤷‍♂️

My original reasoning for making the `auth` and `email` apps _separate_
was so that anyone working on `auth` didn't have to think about `email`.
But ... given that `swoosh` is included in `Phoenix` by `default`
(i.e. you have to _manually_ exclude it with `--no-email` flag)
what is the _advantage_ to _keeping_ them separate? 💭

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.