dwyl / dwyl/contributing

What to do once you have addresses a reviewer's comments

Open
#102 2 comments 1 reaction 0 assignees View on GitHub
help wanted priority-3 starter
Dominant language
No language data
Stars
91
Forks
9
PR merge metrics
No merged PRs in 30d

Description

I have recently seen a couple of instances at dwyl where after addressing a reviewer's comments, the original creator of the PR merges their own PR without passing this back to the reviewer to ensure their comments have been satisfactorily addressed.

It has brought to my attention that this section in our documentation does not address this situation and needs to be made more explicit: https://github.com/dwyl/contributing#step-4-reviewers-review-comment-on-and-merge-the-pull-request

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.