dwyl / dwyl/auth_plug

Chore: Strip `JWT` from URL once authenticated

Open
#113 0 comments 0 reactions 1 assignee Claimed by @nelsonic View on GitHub
bug chore priority-1 T25m technical user-feedback
Dominant language
Elixir
Stars
37
Forks
2
Avg merge
2h 27m
Merged PRs (30d)
1

Description

As noted in https://github.com/dwyl/auth/issues/268 the `JWT` for a successfully authentication session remains in the `URL`:
![image](https://user-images.githubusercontent.com/194400/220829524-6b0649d7-c9c3-427a-8516-370d13201db2.png)

This is undesirable because if there was a _malicious_ `` on the page
or someone loaded an `` on the page that made an outbound `HTTP Request`,
the `JWT` would be in the referrer header of the request
and thus the session could be compromised.
i.e. a malicious actor could just extract the `JWT` from their logs
and replay it to gain access to everything the `person` has saved in the dwyl `App`.

> **Note**: this is not an "active exploit". We are still testing our `MVP`.
Nobody has stored any personal/private/important data in the `MVP`
and there has not been any indication of anyone malicious attempting to "steal" a `JWT`.
I am opening this issue _proactively_ to resolve this ***`before`*** it becomes an exploit.

# Todo

+ [ ] Strip `jwt` from `URL` once the session has been established.

> **Note**: this will be rolled into the `V2` update "Coming Soon" ... 🔜
So please ignore it until then. 👌

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.