dwyl / dwyl/auth

Restrict Who Can See List of People in Prod

Open
#171 0 comments 0 reactions 0 assignees View on GitHub
chore discuss enhancement priority-2 T2h technical
Dominant language
Elixir
Stars
141
Forks
8
PR merge metrics
No merged PRs in 30d

Description

At present, a non-admin person can see the complete list of people who have authenticated with `auth` on our `test` version: https://dwylauth.herokuapp.com/people

![image](https://user-images.githubusercontent.com/194400/147793605-65a41da8-2e5d-40f6-8cb3-3c68e3837e46.png)

This is a _useful_ feature during development because we can immediately see who has logged in & when. but ...
It's _obviously_ undesirable as it's "leaking" Personally Identifiable Information ([PII](https://github.com/dwyl/fields/issues/87))
Even though this is a Test System, we still don't want to let _anyone_ see who has authenticated.
So I propose we restrict the data visible in this view to only the **`admin`** of the App and **`superadmin`**.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the /people view in the test auth deployment and identify how access is currently checked. Confirm the existing admin and superadmin roles, then verify that other users cannot see the authenticated people list while those roles still can. Done means the PII is no longer exposed at /people.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
authorization, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.