dwyl / dwyl/auth

Simplify/Split auth_controller

Open
#168 1 comment 1 reaction 0 assignees View on GitHub
chore enhancement priority-2 T4h technical
Dominant language
Elixir
Stars
141
Forks
8
PR merge metrics
No merged PRs in 30d

Description

As noted by @SimonLab in the PR https://github.com/dwyl/auth/pull/159 the **auth_controller** is _way_ too big.
The file is currently **507** lines. This is *far* too long.

https://github.com/dwyl/auth/blob/76c0161d038e3d8c3840097c37e03c1d967f6b67/lib/auth_web/controllers/auth_controller.ex#L497-L507

# Todo

+ [ ] Review the file and determine if we can extract generic/helper functions
+ [ ] Extract email+password related auth code into its own file, filename at your discretion.
+ [ ] Remove OAuth (Google / GitHub) related code

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.