dwmkerr / dwmkerr/node-imagemagick-cli

convert issue doesn't seem to be solved on windows

Open
#46 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
8
Forks
3
PR merge metrics
No merged PRs in 30d

Description

This code
```js
const imagemagickCli = require('imagemagick-cli')

//...
//...

imagemagickCli
.exec(`convert ${filename} -strip ${filename + '.min'}`)
.then(({ stdout, stderr }) => {
if (stderr) {
callback(Error('Error compressing ' + filename + '. ' + stderr))
} else {
// removes original and renames
fs.unlinkSync(filename)
fs.renameSync(filename + '.min', filename)
}
}).catch(err => {
callback(Error('Error compressing ' + filename + '. ' + err))
})
```

return this on windows

```
Error: Error compressing D:\a\autocosts\autocosts\bin\public\favicon.png. Error: Failed to call 'convert D:\a\autocosts\autocosts\bin\public\favicon.png -strip D:\a\autocosts\autocosts\bin\public\favicon.png.min', which was mapped to '"C:\Windows\System32\convert.exe" D:\a\autocosts\autocosts\bin\public\favicon.png -strip D:\a\autocosts\autocosts\bin\public\favicon.png.min'. Error is 'Command failed: "C:\Windows\System32\convert.exe" D:\a\autocosts\autocosts\bin\public\favicon.png -strip D:\a\autocosts\autocosts\bin\public\favicon.png.min
Invalid Parameter - -strip
'.
at D:\a\autocosts\autocosts\build\compressImages.js:39:17
at D:\a\autocosts\autocosts\node_modules\async\dist\async.js:2955:19
at wrapper (D:\a\autocosts\autocosts\node_modules\async\dist\async.js:268:20)
at iteratorCallback (D:\a\autocosts\autocosts\node_modules\async\dist\async.js:493:17)
at D:\a\autocosts\autocosts\node_modules\async\dist\async.js:321:20
at D:\a\autocosts\autocosts\node_modules\async\dist\async.js:2953:17
at D:\a\autocosts\autocosts\build\compressImages.js:130:11
at processTicksAndRejections (internal/process/task_queues.js:97:5)
npm ERR! Test failed. See above for more details.
Error: Process completed with exit code 1.
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.