dwmkerr / dwmkerr/effective-shell
Issues in Chapter 7: Advanced Text Manipulation with SED
- Dominant language
- JavaScript
- Stars
- 780
- Forks
- 93
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 3
Description
There are issues in Chapter 7 of the No Starch Press book.
1. In the "Stripping Comments" section on page 89, the first sed command is:
> sed -E ′s/\s*#.*$//′ backup-config.sh
The second sed command is:
> sed -E -e ′s/#.*$//′ -e ′/^\s*$/d′ backup-config.sh
Note the differing use of "\s" in the two commands. It is not clear why "\s" is used in either command. And removing it does not change the results.
2. On page 95, the last sentence reads:
> All you’ve done is change the value pattern from [^″] (“anything except
quotes”) to [^0-9] (“anything except quotes and digits”).
The " ... to [^0-9] ..." bit should be, " ... to [^"0-9] ...", note the missing " in the [].
Contributor guide
Research direction
Locate the source for Chapter 7 and review the “Stripping Comments” section on page 89 and the final sentence on page 95. Update the documented sed explanation and the missing quote in the character class, then verify both passages match the requested wording.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100