dwmkerr / dwmkerr/angular-modal-service

Any way to set the default close delay time?

Open
#87 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
618
Forks
312
Avg merge
3d 23h
Merged PRs (30d)
1

Description

I'm using angular-modal-service with bootstrap modals and I've run into an issue where close is being run before the modal animation is complete. I've added

```
$scope.close = function () {
close(null, 500);
};
```

to my scope and when the modal is closed using that function everything is OK but when clicking the backdrop or hitting escape, that function isn't being fired.

Is there any way to set the default close delay for all modals or get my custom close running when the user closes the modal in alternative ways?

![screen shot 2015-07-16 at 10 54 10 am](https://cloud.githubusercontent.com/assets/7562691/8731013/5a10426a-2ba9-11e5-81ed-9218147263cd.png)

Thanks.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing how angular-modal-service handles backdrop clicks, Escape, and the close callback when Bootstrap modal animations are active. Compare those paths with the shown close(null, 500) usage. Done means all supported close paths consistently honor a configurable default delay or invoke the custom close behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.