dwavesystems / dwavesystems/dwave-scikit-learn-plugin
Consider multiplying the quadratic biases in `SelectFromQuadraticModel.correlation_cqm()` by `1-alpha`.
- Dominant language
- Python
- Stars
- 18
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Currently, it is possible to construct a dataset where, even with `alpha=1`, a fixed or random column is chosen because of the penalties in the quadratic term. This contradicts [the docstring](https://github.com/dwavesystems/dwave-scikit-learn-plugin/blob/7db7d03c7b2b17db6309907069ade9aee0e4157a/dwave/plugins/sklearn/transformers.py#L132-L140) which claims
```
alpha:
Hyperparameter between 0 and 1 that controls the relative weight of
the relevance and redundancy terms.
``alpha=0`` places no weight on the quality of the features,
therefore the features will be selected as to minimize the
redundancy without any consideration to quality.
``alpha=1`` places the maximum weight on the quality of the features,
and therefore will be equivalent to using
:class:`sklearn.feature_selection.SelectKBest`.
```
One solution is to multiply the quadratic/redundany terms by `1-alpha` to ensure that they are zeroed when `alpha=1`.
For instance we could replace https://github.com/dwavesystems/dwave-scikit-learn-plugin/blob/7db7d03c7b2b17db6309907069ade9aee0e4157a/dwave/plugins/sklearn/transformers.py#L210-L212 with
```python
diag = np.array(correlations[:, -1] * (-2 * alpha * num_features), copy=True)
correlations *= (1-alpha)
# our objective
# we multiply by 2 because the matrix is symmetric
np.fill_diagonal(correlations, diag)
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.