dwavesystems / dwavesystems/dwave-pytorch-plugin

Flaky tests when using `model_probably_good`

Open
#50 2 comments 1 reaction 1 assignee Claimed by @kevinchern View on GitHub
tests
Dominant language
Python
Stars
39
Forks
25
Avg merge
28m
Merged PRs (30d)
1

Description

Tests using `model_probably_good` are flaky and sometimes fail.

```
..................................................F....
======================================================================
FAIL: test_SkipLinear_different_dim (test_nn.TestLinear.test_SkipLinear_different_dim)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/distiller/project/tests/test_nn.py", line 86, in test_SkipLinear_different_dim
self.assertTrue(model_probably_good(model, (din,), (dout, )))
AssertionError: False is not true
```

Should look into either switching them out for non-random tests or make sure that they pass with much more certainty.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.