dvf / dvf/blockchain-book

"Messaging Protocol" sent incorrectly

Open
#5 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
254
Forks
80
PR merge metrics
No merged PRs in 30d

Description

https://github.com/dvf/blockchain-book/blob/8642a7b55b1b14be40e243cf004051d4f200d4b5/chapters/chapter_7/funcoin/peers.py#L38

In this piece of code above, the struct for var "message' doesn't have "name"
because in `server.py`, it pass different with "meta" and "message"

https://github.com/dvf/blockchain-book/blob/8642a7b55b1b14be40e243cf004051d4f200d4b5/chapters/chapter_7/funcoin/server.py#L30

i'm fix it with:
```
message = message['message']
handler = message_handlers.get(message["name"])
```
added this above in line 38 in `peers.py`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.