dvf / dvf/blockchain-book

Initialising p2p_protocol with self.

Open
#2 1 comment 4 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
254
Forks
80
PR merge metrics
No merged PRs in 30d

Description

I got the error stating that `handle_message` missing positional argument `writer` but `writer` is supplied to the function. It seems that `handle_message` can't get `self`, that is p2p_protocol.

https://github.com/dvf/blockchain-book/blob/8642a7b55b1b14be40e243cf004051d4f200d4b5/chapters/chapter_7/funcoin/server.py#L17

I've changed this section to `self.p2p_protocol = p2p_protocol(self)` and it's working as intended. Is this normal or am I missing something?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.