duo-labs / duo-labs/cloudmapper

More closely following the AWS SDK environmental variables

Open
#706 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
6.3k
Forks
836
PR merge metrics
No merged PRs in 30d

Description

I noticed that `collect` failed in an environment where e.g. `aws sts get-caller-identity` worked. There are two factors:

1. collect looks for `AWS_REGION` but the value typically used is `AWS_DEFAULT_REGION` (see https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html): https://github.com/duo-labs/cloudmapper/blob/ceebed149f9d86f8c9db17f3633fe6da0bf43436/commands/collect.py#L211

2. collect does not check the `AWS_PROFILE` environmental variable so anyone using a non-default profile will have failures unless they specify `--profile` as well.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.