duneanalytics / duneanalytics/spellbook
CoW Protocol: Misleading dex_swaps Evaluation
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 1.4k
- Avg merge
- 3d 16h
- Merged PRs (30d)
- 22
Description
In the early days (before many exotic interactions were happening) this case statement was a fairly-accurate count of the number of dex swaps in a batch. However now we are seeing many other function selectors occurring in settlement interactions. Its probably too difficult to capture/classify dex swaps
Recommend deprecating this field.
(also copied over through all networks where cow is deployed).
cc @harisang, @fhenneke
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with dbt_subprojects/hourly_spellbook/models/_project/cow_protocol/arbitrum/cow_protocol_arbitrum_batches.sql at lines 39-46, then locate the corresponding Cow Protocol batch models for the other deployed networks. Review how dex_swaps is calculated and where it is exposed; done means the field is consistently deprecated across those network models without affecting the remaining batch outputs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- sql
- Domain
- data-engineering
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100