duneanalytics / duneanalytics/evm.codes

Inconsistent argument names for DUP and SWAP instructions

Open
#383 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
827
Forks
199
Avg merge
15m
Merged PRs (30d)
1

Description

For DUP2 and DUP3, the ignored arguments are named (a and a, b) but for DUP4 ... DUP16 they aren't named (which make more sense since they aren' t used by the instruction).

Same for SWAP2 which is inconsistent with SWAP3 ... SWAP16

Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the DUP2 and DUP3 argument labels with the DUP4-DUP16 entries, then do the same for SWAP2 through SWAP16 in the opcode reference. Update the inconsistent ignored-argument names so the instruction listings use one convention, and verify the rendered reference shows matching labels.

Written by the indexing model from the issue text.

Assessment

Tech stack
blockchain, typescript
Domain
blockchain, documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.