duesee / duesee/imap-codec

`ValidationError` & `ValidationErrorKind::Invalid` is useless without information of what the invalid value and what type was expected

Open
#606 10 comments 0 reactions 0 assignees View on GitHub
breaking enhancement
Dominant language
Rust
Stars
52
Forks
25
Avg merge
21h 53m
Merged PRs (30d)
2

Description

`ValidationError` & `ValidationErrorKind::Invalid` is useless without information of what the invalid value and what type was expected.

Both types derive traits which would break if we added extra information:

https://github.com/duesee/imap-codec/blob/086523d64095fd7da35b4fe5ffe27067185c9801/imap-types/src/error.rs#L9-L13

But is a validation error really equal to another validation error if the value domain and/or the value are different? 🤔 Do these errors need to be hashable/orderable/comparable?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.