duckduckgo / duckduckgo/Android
[Bug] Favorites sometimes get an incorrect icon
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 4.8k
- Forks
- 1.4k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 170
Description
Describe the bug
Sometimes favorites on the home screen get the incorrect icon assigned. They may be correct at initial setup, but at some point, undetermined, the icon may change to that of another favorite. This appears to have been reported back in 2020 (and fixed?) in IOS (issue #794), but I'm still seeing the issue in Android as of today. It occurs on multiple devices and has different incorrect favorite icons (even though the devices are synced).
How to Reproduce
The attached image shows three favorites. The first (BBC News) has inherited that of BBC Sport, while the 3rd one (Solus) has inherited what I think was that of BBC news.
Version of Duckduckgo is 5.224.0
Expected behavior
I expect all favorites to retain their correct icon.
Environment
- DDG App Version: 5.224.0
- Device: Samsung Galaxy Tab S7 (and Honor 9)
- OS: Android 13 (and Honor 9)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the incorrect favorite icons on the reported Android devices and versions, using the provided BBC News, BBC Sport, and Solus examples. Trace when favorite icons are assigned, persisted, and synchronized, then verify that each favorite retains its own icon across reloads and sync.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100