duckduckgo / duckduckgo/Android
[Bug] Can't specifiy protocol in "Unprotected Sites" exceptions
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 4.8k
- Forks
- 1.4k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 170
Description
Describe the bug
Seems like the "Unprotected Sites" feature does not allow any URL the users enters and will default to https for all entered domains.
There are various scenarios in which users would want to add exception on pages using various other protocols.
(Here is just a quick address I had handy but this is a general issue)
How to Reproduce
- go to Settings -> Unprotected Sites
- tap the "+" to add a new exception
- try to add any URL with any protocol
- the exception is not added and there is a toast informing about the need to not use a protocol
Expected behavior
Different protocols may serve different pages.
Users may want to be protected or not on any Internet page.
It should be possible to add any exception here with any protocol.
Environment
Happens on any device with any recent version of DDG.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Settings → Unprotected Sites flow and reproduce the validation when adding a URL with a non-HTTPS protocol. Trace where the entered exception is rejected, then verify that URLs using other protocols can be added while existing exception behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile-dev, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100