duckduckgo / duckduckgo/Android
[Bug] Does not respect DuckDuckGo settings for GET/POST requests
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 4.8k
- Forks
- 1.4k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 170
Description
Describe the bug
If you turn off GET requests in DuckDuckGo Privacy settings, the app will still use GET requests anyway instead of switching to POST. This can be verified by bookmarking a search result page and checking the bookmarked url.
How to Reproduce
Steps to reproduce the behavior:
- Do any search on DuckDuckGo
- Scroll right through the headers at the top until you reach settings
- Click "All Settings", then Privacy, and set GET requests to Off
- Make other web searches and bookmark the URLs
- Notice how the URLs contain the search request when they shouldn't
Expected behavior
Switching off GET should use POST instead
Smartphone (please complete the following information):
- DDG App Version: 5.78.1
- Device: Nexus 5
- OS: Android 7.1.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by tracing how the Android app builds DuckDuckGo search requests and reads the Privacy setting for GET requests; reproduce the bookmarked-URL behavior with GET disabled. Done means searches use POST when that setting is off and the resulting URLs no longer expose the search request.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100