duckdb / duckdb/duckdb-spatial

vcpkg duckdb feature support for spatial

Open
#703 1 comment 0 reactions 0 assignees View on GitHub
build system
Dominant language
C
Stars
708
Forks
96
Avg merge
1d 21h
Merged PRs (30d)
5

Description

Hi @Maxxen, I noticed that this specific extension isn't supported as a feature in [microsoft's vcpkg duckdb feature list](https://github.com/microsoft/vcpkg/blob/master/ports/duckdb/vcpkg.json#L18).
Is this due to the extension still being classified as [experimental](https://duckdb.org/docs/stable/core_extensions/overview#list-of-core-extensions)?
I've tried to add it as a custom port feature similar to the other features by updating the [portfile.cmake](https://github.com/microsoft/vcpkg/blob/master/ports/duckdb/portfile.cmake#L51) and vcpkg.json with the following.
```cmake
if("spatial" IN_LIST FEATURES)
vcpkg_from_github(
OUT_SOURCE_PATH DUCKDB_SPATIAL_SOURCE_PATH
REPO duckdb/duckdb-spatial
REF 2d2cc451e35073e738330eb95550a3eba88ca022
SHA512 216a0325237a695b44bfb5daea62096132c8727a360c7de517319527cebc1b9f672215b20b8f4dcab5929d8fb1a12c92e7a94a5901848f59c128ee87f230d579
HEAD_REF main
)
file(RENAME "${DUCKDB_SPATIAL_SOURCE_PATH}" "${SOURCE_PATH}/extension/spatial")
endif()

string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "static" DUCKDB_BUILD_STATIC)
string(COMPARE EQUAL "${VCPKG_LIBRARY_LINKAGE}" "dynamic" DUCKDB_BUILD_DYNAMIC)

set(EXTENSION_LIST "autocomplete;excel;httpfs;icu;json;spatial;tpcds;tpch")
```

However, I get a lot of errors relating to
```
buildtrees/duckdb/src/v1.4.1-61c1f2c740.clean/src/include/duckdb/main/extension_util.hpp:7:15: error: static assertion failed: The DuckDB 'ExtensionUtil' class has been removed, see this PR for more details: https://github.com/duckdb/duckdb/pull/17772
```
And a lot of api calls to ```ExtensionUtil::RegisterCastFunction(...```.

Do you know what the resolution is for these errors, and/or is there a timeline for when the spatial feature would be added to vcpkg?

Thanks

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.