duckdb / duckdb/duckdb-node

statement.run() signature

Open
#98 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
91
Forks
36
PR merge metrics
No merged PRs in 30d

Description

The `statement.run()` method seems to have an entirely different signature than stated in the doc.

### Doc
https://duckdb.org/docs/api/nodejs/reference#statementrunsql-params-callback--void

Here the signature is similar to `connection.run()`, which makes sense.

### Reality
https://github.com/duckdb/duckdb-node/blob/a5ec8f3f48c0f8a74007f95c06ac8908d0ca382e/test/prepare.test.ts#L55

In reality, the values need to be spread as distinct arguments to the function (I checked that it is the case). This seems strange...

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.