duckdb / duckdb/duckdb-java

DuckDBConnection.prepareStatement methods could be less strict

Open
#82 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
127
Forks
80
Avg merge
13h 49m
Merged PRs (30d)
48

Description

The `prepareStatement` methods in `DuckDBConnection` here:
https://github.com/duckdb/duckdb-java/blob/f7ae8cb492d5ffedec1042fbcfacc14ea3e03de5/src/main/java/org/duckdb/DuckDBConnection.java#L296

are currently all stubbed with `throw new SQLFeatureNotSupportedException("prepareStatement")`.

Until they are fully implemented, they could be rewritten so that certain calls may proceed if generated keys are not required. For instance, the call at L296 could be rewritten to:
```java
public PreparedStatement prepareStatement(String sql, int autoGeneratedKeys) throws SQLException {
if (autoGeneratedKeys == NO_GENERATED_KEYS) {
return prepareStatement(sql);
} else {
throw new SQLFeatureNotSupportedException("prepareStatement");
}
}
```

These methods as written are currently keeping me from utilizing duckdb with the [Jetbrains Exposed](https://github.com/JetBrains/Exposed) API, because the connection wrappers call `prepareStatement([sql], NO_GENERATED_KEYS)` instead of `prepareStatement([sql])`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.