duckdb GlobFiles API has been chanced since 1.5.0.
- Dominant language
- C++
- Stars
- 62
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Description
There is a compilation error with duckdb 1.5.0.
```
src/excel/xlsx/read_xlsx.cpp:447:34: error: no matching function for call to ‘duckdb::FileSystem::GlobFiles(const std::__cxx11::basic_string&, duckdb::ClientContext&, duckdb::FileGlobOptions)’
447 | auto files = fs.GlobFiles(file_path, context, FileGlobOptions::ALLOW_EMPTY);
| ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
https://github.com/duckdb/duckdb-excel/blob/9421a2d75bd7544336caa73e5f9e6063cc7f6992/src/excel/xlsx/read_xlsx.cpp#L447
The reason seems duckdb GlobFiles API has been changed since 1.5.0.
https://github.com/duckdb/duckdb/commit/4b3883f421b8b28ee096e5879c2bcd3ba8035047
Are there any plan to support version 1.5.0?
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at src/excel/xlsx/read_xlsx.cpp:447 and compare the GlobFiles API change in the linked DuckDB commit. Build the Excel extension against DuckDB 1.5.0 and verify that the compilation error is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100