dtolnay / dtolnay/serde-stacker
Illegal JSON does not return correct Error value
- Dominant language
- Rust
- Stars
- 38
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Illegal JSON like `1@` will be normally parsed into `Number(1)` instead of returning an Error.
This behavior is different from the regular `serde_json` crate.
Test code:
```Rust
use serde::Deserialize;
use serde_json::Value;
fn main() {
let json = "1@";
let data = json.as_bytes();
let v = serde_json::from_slice::(data);
println!("serde-json: {:?}", v);
let mut deserializer = serde_json::Deserializer::from_slice(data);
deserializer.disable_recursion_limit();
let deserializer = serde_stacker::Deserializer::new(&mut deserializer);
let v = Value::deserialize(deserializer);
println!("serde-stacker: {:?}", v);
}
```
Output:
```
serde-json: Err(Error("trailing characters", line: 1, column: 2))
serde-stacker: Ok(Number(1))
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reproducing the issue with serde_json::Deserializer, serde_stacker::Deserializer, and Value::deserialize using the provided `1@` example. Trace how serde-stacker completes deserialization and add a regression test showing that trailing characters return an Error like serde_json rather than Ok(Number(1)).
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100