dtolnay / dtolnay/rustversion

Matching wrong nightly versions by 1 day

Open
#41 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
394
Forks
22
PR merge metrics
No merged PRs in 30d

Description

version: `rustversion = "1.0.14"`

```rust
#[rustversion::nightly(2023-09-13)]
fn main() {
println!("Hello, world!");
}
```

With `nightly-2023-09-13`:
```shell
cargo +nightly-2023-09-13 b
Compiling rustversion v1.0.14
Compiling rust-version-test v0.1.0 (D:\git-repos\github\rust-version-test)
error[E0601]: `main` function not found in crate `rust_version_test`
--> src\main.rs:4:2
|
4 | }
| ^ consider adding a `main` function to `src\main.rs`

For more information about this error, try `rustc --explain E0601`.
error: could not compile `rust-version-test` (bin "rust-version-test") due to previous error
```
With `nightly-2023-09-14`:
```shell
cargo +nightly-2023-09-14 b
Compiling rustversion v1.0.14
Compiling rust-version-test v0.1.0 (D:\git-repos\github\rust-version-test)
Finished dev [unoptimized + debuginfo] target(s) in 1.86s
```

As you can see, it fails to compile on `nightly-2023-09-13`, but succeeds on `nightly-2023-09-14`. I would expect the opposite behaviour to be true. It seems like the nightly version name is off by 1 compared to what rustversion thinks it is. I'm not sure if this is a bug in `rustversion` or in how the rust releases tag their names.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.