dtolnay / dtolnay/reflect

Instantiation of literals

Open
#26 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
780
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Before introducing a thread_local WipFunction in #13, the only way for us to attach literals into the right WipFunction was by constructing them through methods of MakeFunction, as in `f.unit()` and `f.string("...")`.

Now that we have a thread_local way to track what goes where, these literal constructors would make more sense as plain functions rather than methods of MakeFunction: `reflect::unit()` and `reflect::string("...")`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the existing MakeFunction methods f.unit() and f.string("...") and the thread_local WipFunction introduced in #13. Update the literal-construction API to use reflect::unit() and reflect::string(...), then verify that literals still attach to the correct WipFunction.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.