dtolnay / dtolnay/proc-macro2

Documentation update for span line/end/etc?

Open
#520 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
934
Forks
135
PR merge metrics
No merged PRs in 30d

Description

The documentation for `proc-macro2` still says:

```Available on crate feature span-locations only.
Get the starting line/column in the source file for this span.

This method requires the "span-locations" feature to be enabled.

When executing in a procedural macro context, the returned line/column are only meaningful if compiled with a nightly toolchain. The stable toolchain does not have this information available. When executing outside of a procedural macro, such as main.rs or build.rs, the line/column are always meaningful regardless of toolchain.
```

With similar disclaimers for `end`, `file` etc. Since the MSRV is the "latest stable compiler ABI", I imagine these should be updated, and the reference to the nightly toolchain deleted? I'd be happy to raise a PR if you would like.

Thanks for being such an amazing force in the Rust ecosystem!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.