dtolnay / dtolnay/proc-macro-workshop
Sorted: Tests for sorted match expressions do not catch if you always compare to the first arm
Open
- Dominant language
- Rust
- Stars
- 4.9k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
In sorted::check I forgot to update the last arm and ended comparing all arms with the first arm but still all tests (1-8) passed.
I only noticed my error because I was wondering why test 8 did not fail when having an arm that started with a lower case char (lower chase char > "-") before actually impl. it
EDIT:
For test 8 it also would be a good idea to use match arms that start with a lower case letter (e.g. io::Result) because otherwise the order is correct anyways because all upper case chars are less than "_". At least if you use string comparison.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.